Calii010 / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #4

Open farishkash opened 6 years ago

farishkash commented 6 years ago

Overall met expectations

In this first project, I look at two primary items with the main goal being to stop inefficient or bad practices early.

First, did you use divs, ids/classes to manage and organize your HTML content. Good on this. The main issue here is that you use an ID repeatedly instead of using class="price" instead.

Second is your CSS efficient and non-repetitive. You avoided the majority of common errors. Font family is the most common mistake that happens in this first project.

The only major issue is the need to fix the URLs for your images and stylesheet.

To prepare you for the upcoming projects I like you to go to flexboxfroggy.com. See how far you can get, the later projects uses flexbox heavily and this will help you immensely.

Calii010 commented 6 years ago

2018-03-01 2018-03-01 1

I have changed the points that you mentioned, could you take a look again, I want to know if I've done it the right way