search

Calindra / nonodo

Development Node for Cartesi Rolups
Apache License 2.0
14 stars 14 forks source link

inputter `retryCount` bug #113

Closed ZzzzHui closed 1 month ago

ZzzzHui commented 1 month ago

The retryCount variable in the for loop here https://github.com/Calindra/nonodo/blob/441a98023dc6269002b5129d38fa4231ce9faee3/internal/sequencers/inputter/inputter.go#L95 is not incremented anywhere.

sandhilt commented 1 month ago

Oh! I see. Thanks for feedback @ZzzzHui!

sandhilt commented 1 month ago

@ZzzzHui hi! I and @fabiooshiro decided for keep loop infinite and remove the retry functionality. See more here: https://github.com/Calindra/nonodo/pull/121 Feel free for some additional feedback.

ZzzzHui commented 1 month ago

Hey @sandhilt Looks great!!