Calinou / scoop-games

Scoop bucket for open source/freeware games and game-related tools
Creative Commons Zero v1.0 Universal
293 stars 152 forks source link

OpenTTD: fix architecture and remove baseset installation #1148

Closed WenSimEHRP closed 6 months ago

WenSimEHRP commented 6 months ago

The original manifest file has an error. Win64 and win32 versions are swapped thus it will cause errors on 32-bit computers. Furthermore, the game has arm64 builds provided, so I think it is better to fix the architecture.

This manifest is basically identical with this manifest. I just changed the notes.

Baseset installation (i.e. OpenGFX, OpenMSX, and OpenSFX) are removed because the basesets can be downloaded afterwards, and the game stores them in the user documents folder, in which it is the default content storage folder (all screenshots, mods, basesets, etc.) Plus, the user (e.g. many who have the original TTD graphics, musics and sounds OR they installed the game before) may already have the basesets ready so they don't need extra basesets. Letting the user to download OpenGFX, OpenMSX and OpenSFX for an extra time does not make sense to me.

github-actions[bot] commented 6 months ago

All changes look good.

Wait for review from human collaborators.

openttd