Calinou / scoop-games

Scoop bucket for open source/freeware games and game-related tools
Creative Commons Zero v1.0 Universal
290 stars 151 forks source link

[Bug]: Various issues with `dolphin` #1207

Open RuiNtD opened 2 months ago

RuiNtD commented 2 months ago

Prerequisites

Package Name

dolphin

Expected/Current Behaviour

I noticed there are a few issues with the dolphin packages, such as:

Steps to Reproduce

N/a

Possible Solution

I'm working on the PR to fix most of these issues, but I would like feedback if I should modify the pre_install script to more closely resemble prismlauncher's.

Scoop and Buckets Version

Current Scoop version:
859d1db5 (HEAD -> master, tag: v0.5.2, origin/master, origin/HEAD) chore(release): Bump to version 0.5.2 (#6080)

'main' bucket:
1e2f1397b (HEAD -> master, origin/master, origin/HEAD) radius: Update to version 0.37.0

'extras' bucket:
91a8e2a44 (HEAD -> master, origin/master, origin/HEAD) telegram: Update to version 5.4.1

'versions' bucket:
62beda86f (HEAD -> master, origin/master, origin/HEAD) prismlauncher-git: Update to version 7.0-1b756b9

'nirsoft' bucket:
c22d12d (HEAD -> master, origin/master, origin/HEAD) Update url list [ci skip]

'nerd-fonts' bucket:
b17bbac0 (HEAD -> master, origin/master, origin/HEAD) SarasaGothic: Update to version 1.0.19

'nonportable' bucket:
f73469fd (HEAD -> master, origin/master, origin/HEAD) 10x-np: Update to version 1.0.203

'java' bucket:
84b7bb31 (HEAD -> master, origin/master, origin/HEAD) temurin11-nightly-jre: Update to version 11.0.25-3.0.ea

'games' bucket:
4481f5091 (HEAD -> master, origin/master, origin/HEAD) stonecutter: Update to version 1.2.0

'charm' bucket:
84437d8 (HEAD -> main, origin/main, origin/HEAD) Scoop update for markscribe version v0.8.1

Scoop Config

last_update          scoop_repo                              scoop_branch shim
-----------          ----------                              ------------ ----
8/19/2024 4:43:58 PM https://github.com/ScoopInstaller/Scoop master       kiennq

PowerShell Version

Name                           Value
----                           -----
PSVersion                      7.4.4
PSEdition                      Core
GitCommitId                    7.4.4
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

No response

RuiNtD commented 2 months ago

Everything checked in the issue description is finished in the PR. Everything else I either need assistance or feedback on.

Calinou commented 2 months ago

ARM URL for dolphin-dev is complicated, since the "rand1" and "rand2" matches aren't the same as X64, probably requiring a custom script, which is beyond my knowledge

It might be worth bringing this up to Dolphin developers to see if the URL can be made more predictable.