search

Call-for-Code-for-Racial-Justice / Five-Fifths-Voter

Five Fifths Voter is a web application tool designed to enable and empower Black people and others to exercise their right to vote by ensuring their voice is heard
Apache License 2.0
67 stars 38 forks source link

Adding exteralize string support for i18n #192

Closed upkarlidder closed 3 years ago

upkarlidder commented 3 years ago

This is still work in progress. Please do not merge. @davidnixon, @GeraldMit please review when you get a chance.

The languages files were generated with Google Translate Watson Translation service and should not be added to production in their current state.

Externalize all pages and components

The labels in the countdown widget are currently fixed, but there is a PR to make them dynamic. We can externalize the labels once it is merged in the original widget.

Landing page in Hindi. The language picker on top is just a place holder to test.

image

upkarlidder commented 3 years ago

Externalized strings for a few more pages. Still have a few pages to go.

aleggett23 commented 3 years ago

Hi team! This looks great! This is so touching because there is now an opportunity to reach and help even more individuals by tackling those language barriers🦾💪🏾🙌🏾

I agree that in terms of deciding whether to translate the Five Fifths Voter name, it may be easier from a dev standpoint, more consistent, and more fluid when connecting different cultures together from a brand building perspective to keep it Five Fifths Voter throughout as is for now like in #3.

I was thinking about brands like Facebook, Twitter, and other platforms for example that have language options/international versions but are still known by the original name for the most part. The name itself also has several underlying meanings, so direct translations of it through multiple languages may prove to make some confusion down the road. I think too when people refer the product in whatever culture or demographic, that keeping the same core name may promote a common point of reference, even when the site is translated.

Is this what you were expressing in #3 @upkarlidder @GeraldMit ? Also with the quotes, I added those, and can also be of help with determining how it may be most user-friendly if need be.

sebastianhuynh-nyc commented 3 years ago

Hi, I do agree that the name should be kept as it is, with that said, we need to explore a formal branding for the solution. Upkar, lets find time to chat and see what we can do now and what we want to do in the mid term.

          Sebastian Huynh Design Lead Industry Marketing   IBM ORIGINALS  

    Sebastian Huynh E-mail: @.     ----- Original message -----From: "aleggett23" @.>To: "Call-for-Code-for-Racial-Justice/Five-Fifths-Voter" @.>Cc: "sebastianhuynh-nyc" @.>, "Assign" @.***>Subject: [EXTERNAL] Re: [Call-for-Code-for-Racial-Justice/Five-Fifths-Voter] WIP - adding exteralize string support for i18n (#192)Date: Wed, Aug 25, 2021 10:12 AM  Hi team! This looks great! This is so touching because there is now an opportunity to reach and help even more individuals by tackling those language barriers 🦾 💪🏾🙌🏾 I agree that in terms of deciding whether to translate the Five Fifths Voter ZjQcmQRYFpfptBannerStart

This Message Is From an External Sender This message came from outside your organization. ZjQcmQRYFpfptBannerEnd   Hi team! This looks great! This is so touching because there is now an opportunity to reach and help even more individuals by tackling those language barriers🦾💪🏾🙌🏾 I agree that in terms of deciding whether to translate the Five Fifths Voter name, it may be easier from a dev standpoint, more consistent, and more fluid when connecting different cultures together from a brand building perspective to keep it Five Fifths Voter throughout as is for now like in #3. I was thinking about brands like Facebook, Twitter, and other platforms for example that have language options/international versions but are still known by the original name for the most part. The name itself also has several underlying meanings, so direct translations of it through multiple languages may prove to make some confusion down the road. I think too when people refer the product in whatever culture or demographic, that keeping the same core name may promote a common point of reference, even when the site is translated. Is this what you were expressing in #3 @upkarlidder @GeraldMit ? Also with the quotes, I added those, and can also be of help with determining how it may be most user-friendly if need be. —You are receiving this because you were assigned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.  

krook commented 3 years ago

Also a +1 on keeping "Five Fifths Voter" as the universal name.

Perhaps a stylized icon or logo without the text (maybe incorporating the numbers 5/5) can achieve some degree of extra internationalization?

aleggett23 commented 3 years ago

Sounds good @sebastianhuynh-nyc & Great idea @krook! The team has been mentioning a logo idea for a while! It was a GitHub issue at one point but not sure if it still is.

Maybe deciding upon a logo could be a portion of the formal branding process that @sebastianhuynh-nyc is referring to.

upkarlidder commented 3 years ago

Sounds good @sebastianhuynh-nyc & Great idea @krook! The team has been mentioning a logo idea for a while! It was a GitHub issue at one point but not sure if it still is.

Maybe deciding upon a logo could be a portion of the formal branding process that @sebastianhuynh-nyc is referring to.

Thank you @aleggett23 and @sebastianhuynh-nyc. I will keep working on externalizing the strings. @aleggett23 can you please get us together to talk branding/logo/i18n?

aleggett23 commented 3 years ago

@upkarlidder Thank you so much for your hard work, and absolutely! I will message you about potential options.

upkarlidder commented 3 years ago

@GeraldMit @davidnixon can you please merge when you get a chance. I am done with this PR.

@davidnixon I assume this will kick off a build and reflect on the production site? I took out the language selection, but left the translated files in there.

upkarlidder commented 3 years ago

@GeraldMit @davidnixon can you please merge when you get a chance. I am done with this PR.