move language selector to a panel to resolve mobile issue. Add transl… - Githubissues

Call-for-Code-for-Racial-Justice / Five-Fifths-Voter

Five Fifths Voter is a web application tool designed to enable and empower Black people and others to exercise their right to vote by ensuring their voice is heard

Apache License 2.0

67 stars 38 forks source link

move language selector to a panel to resolve mobile issue. Add transl… #256

Closed davidnixon closed 3 years ago

davidnixon commented 3 years ago

…ations to mobile side nav.

Signed-off-by: David Nixon dwnixon@gmail.com

Contributes to #255

What did you do?

Moved language selector to a panel
Add translations to the mobile side nav

Why did you do it?

Resolve issues

How have you tested it?

Locally desktop + mobile in dev tools

Were docs updated if needed?

[ ] No
[ ] Yes
[x] N/A

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new console logs
[x] Fixes entire issue
[x] Partial fix for issue

upkarlidder commented 3 years ago

This looks good to me. Minor observation, the menu in mobile appear in opposite places for RTL languages. This may be the desired state and I just don't know :)

Approved and merging.