search

Call-for-Code-for-Racial-Justice / Five-Fifths-Voter

Five Fifths Voter is a web application tool designed to enable and empower Black people and others to exercise their right to vote by ensuring their voice is heard
Apache License 2.0
67 stars 37 forks source link

Text doesn't appear on Android app #291

Closed cstefano1 closed 3 months ago

cstefano1 commented 2 years ago

Describe the bug The text "5/5 equals a whole. A whole person…" doesn’t appear on the mobile app

To Reproduce Steps to reproduce the behavior:

  1. Go to mobile app
  2. Notice missing text

Expected behavior I presume the text should be there.

Screenshots Screenshot of web app: image Screenshot of mobile app: image

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

upkarlidder commented 2 years ago

Thank you @cstefano1 for creating this issue. I had not noticed. Anything under 1056px, the text is taken out as the display is set to none. I am guessing this was a design decision taken when the code was written. @davidnixon @sebastianhuynh-nyc probably know more.

https://github.com/Call-for-Code-for-Racial-Justice/Five-Fifths-Voter/blob/4515dc4e6beef5fbc32c724e7ac28d5cd2388733/ui/src/components/Hero/_hero.scss#L210

.hero__description {
  @include carbon--type-style('productive-heading-03');
  display: none;
  max-width: 630px;
  margin-bottom: $spacing-06;

  @media (min-width: 1056px) {
    display: block;
  }
}
github-actions[bot] commented 2 years ago

:wave: Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

cstefano1 commented 2 years ago

Closed by bot; I'm reopening.

github-actions[bot] commented 4 months ago

:wave: Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.