fix deployment to blue service & skip postinstall for deployment

Call-for-Code-for-Racial-Justice / Five-Fifths-Voter

Five Fifths Voter is a web application tool designed to enable and empower Black people and others to exercise their right to vote by ensuring their voice is heard

Apache License 2.0

67 stars 37 forks source link

fix deployment to blue service & skip postinstall for deployment #325

Closed davidnixon closed 2 years ago

davidnixon commented 2 years ago

Signed-off-by: David Nixon dwnixon@gmail.com

Contributes to #306 - partial fix - fixed services deployment for CF

Were docs updated if needed?

[ ] No
[ ] Yes
[x] N/A

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new console logs
[ ] Fixes entire issue
[x] Partial fix for issue

davidnixon commented 2 years ago

Thanks @davidnixon. Looks good. I learned about the test command in linux! I see that we take a different approach in ui service where we use sed to blank out the postinstall command in package.json. Should we not be consistent in our approach? I like this approach better instead of hacking the GitHub action to blank out the script. FYI @GeraldMit

Yep this is just a partial fix. I'll address the ui with more code in #306