Call-for-Code-for-Racial-Justice / TakeTwo-Marker-ChromeExtension

Call For Code Diverse Representation Problem 3 marker chrome extension
MIT License
7 stars 9 forks source link

Close out the login form once the user has logged in #22

Open upkarlidder opened 3 years ago

upkarlidder commented 3 years ago

Is your feature request related to a problem? Please describe. The extension should close out the login form once the user has logged in. The user could also be given a possibility to log out.

Related to #16

image

Describe the solution you'd like Replace the login form with a logout button once the user has been authenticated.

github-actions[bot] commented 3 years ago

:wave: Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed in 14 days.

akshaymattoo commented 3 years ago

@upkarlidder I would like to take this issue.

upkarlidder commented 3 years ago

Sounds good @akshaymattoo. Just confirming with @josiemundi and @sebastiaanzaaijer as I know they were also working on the extension. Thank you!

FYI @demilolu

akshaymattoo commented 3 years ago

@upkarlidder Am I good to start on this issue?

sebastiaanzaaijer commented 3 years ago

Hi @akshaymattoo, yeah that would be great thanks!

akshaymattoo commented 3 years ago

@sebastiaanzaaijer I have made the changes and tested them as well in my local. It works fine. I have a question I am not able to make another branch out of main to generate a pull request. Can you please direct me in that direction on how do I raise a pull request? On the other topic, I would like to make some modifications to the Readme where I would like to add more details. Shall I create an issue for that first and then you can review and let me know if you would like to proceed with that?

upkarlidder commented 3 years ago

Hello @akshaymattoo, pls create a fork first and then you should be able to push to your fork and create a PR from there. Let us know if that does not work. Thank you again for your contribution!

akshaymattoo commented 3 years ago

@upkarlidder I did open the pull request. Thank you for the direction.

github-actions[bot] commented 2 years ago

:wave: Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed in 14 days.

github-actions[bot] commented 2 years ago

:wave: Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed in 14 days.