search

Call-for-Code-for-Racial-Justice / Truth-Loop

The Truth-Loop solution helps communities simply understand the policies, regulations and legislation that will impact them the most and allows them to share their experiences around how policies have impacted them or how proposed policies could impact them using short video testimonials.
https://developer.ibm.com/tutorials/truth-loop/
Apache License 2.0
54 stars 29 forks source link

Refactor react PolicyTable component to not directly access the store #179

Closed ed-snodgrass closed 3 years ago

ed-snodgrass commented 3 years ago

While the useSelector hook is super convenient it isn't an ideal situation to have all components accessing the store. It is likely a better pattern to have *Route component access the store and pass the data to the component. This will make testing the components simpler as well as allow components to be reused more easily.

Goldenhub commented 3 years ago

Would love to work on this

demilolu commented 3 years ago

@Goldenhub it's yours!

demilolu commented 3 years ago

@Goldenhub can you link your PR to this issue?

Goldenhub commented 3 years ago

Hello @demilolu , I've fixed this issue. Can it be closed?

demilolu commented 3 years ago

@Goldenhub can you link your PR so I can take a look? Thanks!

ed-snodgrass commented 3 years ago

@demilolu 👋 here is the pull request. https://github.com/Call-for-Code-for-Racial-Justice/Truth-Loop/pull/213