Call-for-Code-for-Racial-Justice / Truth-Loop

The Truth-Loop solution helps communities simply understand the policies, regulations and legislation that will impact them the most and allows them to share their experiences around how policies have impacted them or how proposed policies could impact them using short video testimonials.
https://developer.ibm.com/tutorials/truth-loop/
Apache License 2.0
54 stars 29 forks source link

202 react admin artifacts and new inputs #251

Closed ed-snodgrass closed 3 years ago

ed-snodgrass commented 3 years ago

Contributes to #202

What did you do?

Added DateInput and SelectInput. Added all components for artifacts

Why did you do it?

Still needed to be done.

How have you tested it?

Created and ran unit tests. Added, edited and deleted artifacts.

Were docs updated if needed?

Type of change

Checklist:

markstur commented 3 years ago

probably should have been separate PRs for the artifact work vs the general purpose fixing. But I can see where it probably didn't seem worthwhile to split things up if you were already in the artifacts work.

ed-snodgrass commented 2 years ago

probably should have been separate PRs for the artifact work vs the general purpose fixing. But I can see where it probably didn't seem worthwhile to split things up if you were already in the artifacts work.

I'm definitely guilty of refactoring other stuff in the same PR ( :) i caught myself and moved the done() callback stuff to its own PR). So I'll continue to keep an eye on that. Usually if it affects what i'm working on then i'll just use the same branch/PR.