Closed ed-snodgrass closed 3 years ago
probably should have been separate PRs for the artifact work vs the general purpose fixing. But I can see where it probably didn't seem worthwhile to split things up if you were already in the artifacts work.
probably should have been separate PRs for the artifact work vs the general purpose fixing. But I can see where it probably didn't seem worthwhile to split things up if you were already in the artifacts work.
I'm definitely guilty of refactoring other stuff in the same PR ( :) i caught myself and moved the done()
callback stuff to its own PR). So I'll continue to keep an eye on that. Usually if it affects what i'm working on then i'll just use the same branch/PR.
Contributes to #202
What did you do?
Added DateInput and SelectInput. Added all components for artifacts
Why did you do it?
Still needed to be done.
How have you tested it?
Created and ran unit tests. Added, edited and deleted artifacts.
Were docs updated if needed?
Type of change
Checklist: