Call-for-Code / DroneAid

Aerial scout for first responders. DroneAid uses machine learning to detect calls for help on the ground placed by those in need.
Apache License 2.0
126 stars 59 forks source link

Unloadable CSS / Javascript dependencies when connected to Tello #16

Closed johnwalicki closed 4 years ago

johnwalicki commented 4 years ago

If your laptop is connected to the Tello Drone hotspot and you try to load the http://127.0.0.1:3000 webpage, the index.html tries unsuccessfully to load the remote CSS page <link rel="stylesheet" href="https://codepen.io/ibmcodait/pen/gVMdwm.css"> and scripts

    <script src="https://cdn.jsdelivr.net/npm/@cloud-annotations/object-detection"></script>
    <script src="https://codepen.io/ibmcodait/pen/gVMdwm.js"></script>

There's some additional recursive dependences within those files too.

Since the laptop is not connected to the internet (at least over wireless), the rendered page is a mess. It would be better to move these dependencies local into this repo so that a Ctrl-R / page reload doesn't wreck the drone demo.

For now the workaround is to :

krook commented 4 years ago

Not sure if the local download wouldn't cause more problems in keeping things up to date, especially in those recursive dependencies. Maybe the best is just to document the workaround more prominently.

johnwalicki commented 4 years ago

Nick B fixed this for me in this commit https://github.com/Code-and-Response/DroneAid/commit/7726dd83b05b7ed7ac28f6028ef1df48fb379d90 We can close this ticket.