search

Call-for-Code / DroneAid

Aerial scout for first responders. DroneAid uses machine learning to detect calls for help on the ground placed by those in need.
Apache License 2.0
122 stars 59 forks source link

droneaid-counter.js doesn't actually count #17

Open johnwalicki opened 4 years ago

johnwalicki commented 4 years ago

Describe the bug The model detects one of the classified images and draws a bounding box but the counter on the web page does not increment

To Reproduce Steps to reproduce the behavior:

  1. View some of the symbol images.
  2. Observe that the model draws bounding boxes.
  3. The web page does not increment
krook commented 4 years ago

@pedrocruzio Thoughts on this one?

johnwalicki commented 4 years ago

Va and I had a chat about this ticket in November. Essentially, it doesn't increment the counter if the prior frames bounding boxes intersect the current bounding box. Which makes sense, the drone found a symbol and is just moving around it. You don't want to count it twice (or hundreds of times).

I still think its fickle and not quite working as expected.

krook commented 4 years ago

@johnwalicki @vabarbosa do we want to keep this issue open?

vabarbosa commented 4 years ago

yes, please keep open. there are still some additional updates i would like to make