Make the theme qBittorrent v5 compatible

[JohanSF]

As binhex writes here: https://github.com/repslet/nightwalker/issues/20#issue-2631251659

Quote:

Hi love this theme, any chance you can fix up the theme to support qBittorrent v5 please.

Things I have noticed so far (there could and probably are more):

• missing paused/stopped icon
• Inability to pause any torrents

It looks like this fork might have fixed these issues: https://github.com/Jorsher/nightwalker

[joshft91]

@Jorsher, if your code is ready, would you be willing to put your fork up for review against CallMeBruce's repo? May be able to get this merged in to get it working for hotio images.

[Jorsher]

@Jorsher, if your code is ready, would you be willing to put your fork up for review against CallMeBruce's repo? May be able to get this merged in to get it working for hotio images.

To be honest, I don't know how to do that and I'm not sure my changes are up to snuff.

Essentially I just find/replace-d all variants of pause/paused/resume/resumed with stop/stopped/start/started. May have even changed some that didn't need to be changed. Because of this, it won't work with versions prior to 5.0. Pause icon should probably be changed to a Stop one too :)

Qbit dark theme wasn't quite as sleek as this and it was the main thing holding me back from upgrading to 5.0.

[rakosi2]

You can create a pull request in the pull request tab. However, you don't want to add the changes to the README so the easiest way is to make a new branch and checkout the main commit or cherry-pick it and pull request that branch. Don't worry about incompatibility for older Qbit as @CallMeBruce could make a new branch for pre-5.0 or people can checkout the version that they want.

[IIIdefconIII]

Unacceptable file type, only regular file is allowed.

[joshft91]

To be honest, I don't know how to do that and I'm not sure my changes are up to snuff.

Essentially I just find/replace-d all variants of pause/paused/resume/resumed with stop/stopped/start/started. May have even changed some that didn't need to be changed. Because of this, it won't work with versions prior to 5.0. Pause icon should probably be changed to a Stop one too :)

Qbit dark theme wasn't quite as sleek as this and it was the main thing holding me back from upgrading to 5.0.

That's fair, I am still on 4.6.7. I wasn't sure the scope of your changes or what has changed in qBittorrent 5 that was breaking with Nightwalker.

Don't worry about incompatibility for older Qbit as @CallMeBruce could make a new branch for pre-5.0 or people can checkout the version that they want.

I'd be a bit cautious about this approach since this repo currently gets bundled into the hotio legacy release. Merging in breaking changes for users using the legacy release would cause problems for them.

[CallMeBruce]

Just did a re-combine of latest 5.0.2 version and the nightwalker theme. Let me know if you find something that isn't working.

[IIIdefconIII]

Sounds really fair man thans for the response

Hartelijke groet,

---

Thomas van Dalen

E: @.**@.>

T: indien nodig

---

From: CallMeBruce @.> Sent: Thursday, November 21, 2024 3:12:55 PM To: CallMeBruce/nightwalker @.> Cc: Thomas van Dalen @.>; Comment @.> Subject: Re: [CallMeBruce/nightwalker] Make the theme qBittorrent v5 compatible (Issue #4)

Just did a re-combine of latest 5.0.2 version and the nightwalker theme. Let me know if you find something that isn't working.

— Reply to this email directly, view it on GitHubhttps://github.com/CallMeBruce/nightwalker/issues/4#issuecomment-2491315289, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACLVJWYXV2BKTX7FIDJGN5D2BXS6PAVCNFSM6AAAAABRTJVIKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJRGMYTKMRYHE. You are receiving this because you commented.Message ID: @.***>