search

Callidon / bloom-filters

JS implementation of probabilistic data structures: Bloom Filter (and its derived), HyperLogLog, Count-Min Sketch, Top-K and MinHash
https://callidon.github.io/bloom-filters/
MIT License
369 stars 42 forks source link

Class Visibility: private -> public/protected? #37

Closed folkvir closed 2 years ago

folkvir commented 3 years ago

Tracking posted by @folkvir in https://github.com/Callidon/bloom-filters/issues/31#issuecomment-875346545_

As explained earlier the visibility of all classes limits the extended capabilities of our own classes. I suggest to change private properties to protected and add getters and setters to all members when possible.

folkvir commented 2 years ago

fix in develop, all propeties will be publicly available.