search

Callisto82 / tftp.net

Implements the TFTP (Trivial File Transfer) protocol (client/server) in an easy-to-use C#/.NET library.
Microsoft Public License
80 stars 38 forks source link

LoggingStateDecorator class #5

Closed FlxGen closed 5 years ago

FlxGen commented 5 years ago

FYI - on a Xamarin.iOS project, System.Diagnostics.Trace.WriteLine(message, transfer.ToString()) in TftpTrace class causes transfers to be very slow in a debug session. I believe its because of the overhead required to print the transfer messages on the debug screen in Visual Studio. I've done some testing and transferring 800mb with WriteLine takes ~10 minutes vs ~80 minutes with WriteLine.

I created a public bool called WriteTrace in TftpServer and TftpClient then passed that to LoggingStateDecorator with if (trace) above TftpTrace.Trace(). May want to consider it in future releases.

Callisto82 commented 5 years ago

Tracing has now been disabled by default. You can re-enable it by setting TftpTrace.Enabled to true.

clefranc commented 4 years ago

Hi Michael, Is TftpTrace.Enabled now set to true by default? Have to disable from NuGet.

Christian

Callisto82 commented 4 years ago

Hi Christian,

yeah, that unfortunately happened some time ago. That error was corrected in March 2019. Since then TftTrace.Enabled is set to false.

I did just publish a new release of the library if you don’t want to compile yourself:

https://github.com/Callisto82/tftp.net/releases/tag/V1.2

Kind regards,

Michael

Von: Christian Lefrançois [mailto:notifications@github.com] Gesendet: Samstag, 13. Juli 2019 19:05 An: Callisto82/tftp.net tftp.net@noreply.github.com Cc: Michael Baer Miki1@gmx.net; State change state_change@noreply.github.com Betreff: Re: [Callisto82/tftp.net] LoggingStateDecorator class (#5)

Hi Michael, Is TftpTrace.Enabled now set to true by default? Have to disable from NuGet.

Christian

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Callisto82/tftp.net/issues/5?email_source=notifications&email_token=AEJW3UR2PQ5YJFTKXXUGZPTP7IDNPA5CNFSM4FMJUQNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ3VTDY#issuecomment-511138191 , or mute the thread https://github.com/notifications/unsubscribe-auth/AEJW3UUWXSR5NVJ4JDZQOLLP7IDNPANCNFSM4FMJUQNA .