Callisto82 / tftp.net

Implements the TFTP (Trivial File Transfer) protocol (client/server) in an easy-to-use C#/.NET library.
Microsoft Public License
80 stars 38 forks source link

Incorrect File Transferring Progress Caused by int-Type Overflow #8

Closed achouman closed 5 years ago

achouman commented 5 years ago

In TftpTransferProgress class, variables are declared as integer type. When calculaing file transfering progress of a large file in the ToString() function, an overflow might happen.

Callisto82 commented 5 years ago

Though this kind of problems seems rather theoretical (given we're talking about TFTP here), the library is now using long instead of int types.