search

CallistoLabsNYC / samsa

Rust-native Kafka/Redpanda protocol and client implementation.
Apache License 2.0
106 stars 5 forks source link

Update Integration tests to use their own topic #79

Closed hgm-king closed 4 months ago

hgm-king commented 4 months ago

Background

In our /tests folder we have integration tests, they each do something like testsupport::get_brokers_and_topic where it returns whether to skip, the brokers, and the topic to use. The test skips if no env variables are set, and the broker url and the topic are set as env variables.

We want to update the tests so that they create a topic with the same name as the test, like [testname]-integration and then delete that topic after running.

This will help our tests run in isolation and not be affected by other tests or previous runs.

morukele commented 4 months ago

Hey @hgm-king I think this is up my alley. If we sort out the current pull request, I will like to work on this issue.

hgm-king commented 4 months ago

@morukele you bet!

morukele commented 4 months ago

Will wait for you to merge the other PR before I go ahead with this!

morukele commented 4 months ago

@hgm-king Assign this one to me so that I do the update.

I am considering using the Rust standard library to get the file name as the test topic. This can be a helper function.

hgm-king commented 4 months ago

You got it! sounds like a nice idea

morukele commented 4 months ago

@hgm-king created a PR for this #90