Callum027 / ipam-migrator

Data migration tool for between phpIPAM and NetBox
GNU General Public License v3.0
17 stars 8 forks source link

Arg mixed in NetBox API backend constructor. #4

Open PawelMack opened 3 years ago

PawelMack commented 3 years ago

Hello,

First of all thanks for sharing the code with the rest of us. It's always good to find solution for the problem that you face.

When using your code I faced an issue as following

  File "/usr/local/lib/python3.8/dist-packages/ipam_migrator-1.0.0-py3.8.egg/ipam_migrator/backend/netbox.py", line 455, in vlans_write
    self.logger.info("Writing VLANs...")
AttributeError: 'str' object has no attribute 'info'
2021-06-18 13:31:10,194 ipam-migrator: [DEBUG] stopping logger

What I found in the code is that in NetBox API backend constructor the args are mixed.

It is super().__init__(name, logger) while it should be super().__init__(logger, name)

Best,