search

Caltech-AMBER / obelisk

A stable generic robot control interface.
https://caltech-amber.github.io/obelisk/
MIT License
5 stars 0 forks source link

Propagate C++ compile options into fetch content #105

Open alberthli opened 3 months ago

alberthli commented 3 months ago

Annoying unused parameter warning appear for instance when importing yaml-cpp because we have no control over fetched code. We should try to suppress these warnings for cleanliness

/path/to/obelisk/obelisk/obelisk_ws/build/obelisk_leap_cpp/_deps/yaml-cpp-src/util/sandbox.cpp: In member function 'virtual void NullEventHandler::OnSequenceStart(const Mark&, const std::string&, anchor_t, YAML::EmitterStyle::value)':
/path/to/obelisk/obelisk/obelisk_ws/build/obelisk_leap_cpp/_deps/yaml-cpp-src/util/sandbox.cpp:21:50: warning: unused parameter 'style' [-Wunused-parameter]
   21 |                        YAML::EmitterStyle::value style) override {}
      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
/path/to/obelisk/obelisk/obelisk_ws/build/obelisk_leap_cpp/_deps/yaml-cpp-src/util/sandbox.cpp: In member function 'virtual void NullEventHandler::OnMapStart(const Mark&, const std::string&, anchor_t, YAML::EmitterStyle::value)':
/path/to/obelisk/obelisk/obelisk_ws/build/obelisk_leap_cpp/_deps/yaml-cpp-src/util/sandbox.cpp:24:45: warning: unused parameter 'style' [-Wunused-parameter]
   24 |                   YAML::EmitterStyle::value style) override {}
      |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
/path/to/obelisk/obelisk/obelisk_ws/build/obelisk_leap_cpp/_deps/yaml-cpp-src/util/read.cpp: In member function 'virtual void NullEventHandler::OnSequenceStart(const Mark&, const std::string&, anchor_t, YAML::EmitterStyle::value)':
/path/to/obelisk/obelisk/obelisk_ws/build/obelisk_leap_cpp/_deps/yaml-cpp-src/util/read.cpp:23:50: warning: unused parameter 'style' [-Wunused-parameter]
   23 |                        YAML::EmitterStyle::value style) override {}
      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
/path/to/obelisk/obelisk/obelisk_ws/build/obelisk_leap_cpp/_deps/yaml-cpp-src/util/read.cpp: In member function 'virtual void NullEventHandler::OnMapStart(const Mark&, const std::string&, anchor_t, YAML::EmitterStyle::value)':
/path/to/obelisk/obelisk/obelisk_ws/build/obelisk_leap_cpp/_deps/yaml-cpp-src/util/read.cpp:26:45: warning: unused parameter 'style' [-Wunused-parameter]
   26 |                   YAML::EmitterStyle::value style) override {}
      |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
---