search

Caltech-IPAC / kete

Kete Solar System Survey tools
https://Caltech-IPAC.github.io/kete
BSD 3-Clause "New" or "Revised" License
12 stars 1 forks source link

Improve mission phase checks #4

Closed dahlend closed 6 months ago

dahlend commented 6 months ago

This makes it more explicit where scan ids are converted to mission phases. This is a bit fuzzy around reactivation year boundaries, but is FAR more accurate.

This has been tested by loading every single field of view through all phases through 2023 december, verifying that it returns the correct phase except near year boundaries where it may be off by a year, but still return "Reactivation_".

It is precisely correct for non-reactivation phases.

dahlend commented 6 months ago

I think we should leave it as is, there are so many edge cases where the user can put in invalid scan-ids. Attempting to enumerate them all would make this code even more complicated.