CaltechOpticalObservatories / NGPS

NGPS Software
2 stars 0 forks source link

aborted target remains active #12

Closed astronomerdave closed 1 year ago

astronomerdave commented 1 year ago

After clicking "Abort" the target remains flagged as active. image

jenniferwillow commented 1 year ago

What behavior would you like? Recall that I don't change the state variable, you do. You change the target to active, then to completed. If I send the cancel, shouldn't the OS then mark the target as completed or change it back to pending. I initially set all of the targets to pending when the list is imported but I never change this after creating it.

astronomerdave commented 1 year ago

I think that is correct, that the sequencer should change the target state; I will look into this.

astronomerdave commented 1 year ago

Found and fixed sequencer bug where an abort did not always necessarily update the target state. If the sequencer is running or paused, an abort will update the target state to "inactive".