search

CaltechOpticalObservatories / NGPS

NGPS Software
2 stars 0 forks source link

implement status messages #27

Open astronomerdave opened 1 year ago

astronomerdave commented 1 year ago

The Messages window only displays somewhat cryptic, short text like "start" ACK "do one" ACK, etc. but should display human-friendly messages to tell the user what is going on. A perfect example where this can be important is shown here,

image

where the user clicked "GO" but nothing happened. Only because I had the listener window running (in yellow) could I see the cause of the error (all NOTICE: messages should probably be displayed in Messages).

jenniferwillow commented 1 year ago

Hi Dave, You are correct. The messages window used to show a lot of text but I kept cutting it down because everyone didn’t want much text here. However, no one (until just now) ever suggested what they wanted in this window. I can easily add things but I need to know when and what. Jennifer

On May 24, 2023, at 5:02 PM, David Hale @.**@.>> wrote:

The Messages window only displays somewhat cryptic, short text like "start" ACK "do one" ACK, etc. but should display human-friendly messages to tell the user what is going on. A perfect example where this can be important is shown here,

[image]https://user-images.githubusercontent.com/3028392/240766720-36c4fa3f-446c-436d-9ae3-289274d18a23.png

where the user clicked "GO" but nothing happened. Only because I had the listener window running (in yellow) could I see the cause of the error (all NOTICE: messages should probably be displayed in Messages).

— Reply to this email directly, view it on GitHubhttps://github.com/CaltechOpticalObservatories/NGPS/issues/27, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFCPAKB74Z7TX6JAQA43ANTXH2OQDANCNFSM6AAAAAAYOCCLTY. You are receiving this because you were assigned.Message ID: @.***>

astronomerdave commented 1 year ago

Understood. I suggest start with the following :

  1. mine the broadcast messages for the tag NOTICE: and add that text (after the tag) to the Messages; I think anything tagged with NOTICE: is useful to display verbatim. And if you can color code (seems like you can since I see blue and black) then color anything that contains the string "ERROR" as red.
  2. mine broadcast messages for state changes and display things like, "waiting for " and then remove that message when no longer waiting (e.g. waiting for slit, waiting for flexure, etc.) If you can't remove messages then I'm not sure, maybe don't say "waiting for..." because that could lead to confusion if it always says waiting....