OTMflag too long for column width

[astronomerdave]

suggest adjusting flag text to fit column, or adjust column width to fit text

[chazshapiro]

The (short) flags are defined in the manual, so we can just use the flag string

I've unassigned myself on this one

[astronomerdave]

@chazshapiro ETC SRCMODEL parameters are also quite long, too long for the display. Maybe that's just the way it has to be? Or could we do better? Could the options be pull-down-selectable (or are there too many possible combinations)?

[chazshapiro]

There are too many options (and growing)

From: David Hale @.> Reply-To: CaltechOpticalObservatories/NGPS @.> Date: Thursday, May 25, 2023 at 10:54 AM To: CaltechOpticalObservatories/NGPS @.> Cc: "Shapiro, Charles A (US 389E)" @.>, Mention @.***> Subject: [EXTERNAL] Re: [CaltechOpticalObservatories/NGPS] OTMflag too long for column width (Issue #29)

@chazshapirohttps://urldefense.us/v3/__https:/github.com/chazshapiro__;!!PvBDto6Hs4WbVuu7!IlpsHfbZSIOfgVDZwy6nlaFoVZVFCMouhluMwK9BLMADUsnS_HJHpAjcjAcsMAg73wOu6mXlVhS2hsHZSe3pwEFAPdIjNwfzUds$ ETC SRCMODEL parameters are also quite long, too long for the display. Maybe that's just the way it has to be? Or could we do better? Could the options be pull-down-selectable (or are there too many possible combinations)?

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https:/github.com/CaltechOpticalObservatories/NGPS/issues/29*issuecomment-1563291059__;Iw!!PvBDto6Hs4WbVuu7!IlpsHfbZSIOfgVDZwy6nlaFoVZVFCMouhluMwK9BLMADUsnS_HJHpAjcjAcsMAg73wOu6mXlVhS2hsHZSe3pwEFAPdIj9D-uLHk$, or unsubscribehttps://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/ACE4SRNPJ4D6JONSTCYBLCDXH6METANCNFSM6AAAAAAYPDIPOE__;!!PvBDto6Hs4WbVuu7!IlpsHfbZSIOfgVDZwy6nlaFoVZVFCMouhluMwK9BLMADUsnS_HJHpAjcjAcsMAg73wOu6mXlVhS2hsHZSe3pwEFAPdIjpZTrHHQ$. You are receiving this because you were mentioned.Message ID: @.***>

[astronomerdave]

OK, SRCMODEL params are one thing, especially since they are editable, but I think we do need error messages (OTMflag) to be fully readable.

[jenniferwillow]

The flags are passed from the OTM and I have no ability to truncate them arbitrarily. I think this is an OTM issue. The GUI simply displays the text that comes in. I'm going to close this as a GUI issue and refer it to Chaz.

[chazshapiro]

We saw a message in OTMflag that was something like "Observation is happening during the day". Where is that coming from?

[chazshapiro]

[jenniferwillow]

Hi Chaz, I was mistaken when I thought this was coming from the OTM. The actual text is in the table code that transforms the original text into the longer string. Here’s the code:

    if(row == 11){
        java.lang.String flag = current.otm.getOTMflag();
        if(flag.contains("ALT")){
           returnObject = "Target's altitude is out of range" ;
        }else if(flag.contains("AIR")){
            returnObject = "Target's airmass is out of range" ;
        }else if(flag.contains("HA")){
            returnObject = "Target's hour angle is out of range" ;
        }else if(flag.contains("DAY")){
            returnObject = "Obervation is happening during daylight" ;
        }else{
            returnObject = current.otm.getOTMflag();
        }

// returnObject = current.otm.getOTMflag(); }

Do you want me to replace the text with the abbreviations? I can do this easily. Sincerely, Jennifer

On Jun 1, 2023, at 3:22 PM, Chaz Shapiro @.**@.>> wrote:

[Screenshot 2023-06-01 at 3 21 53 PM]https://user-images.githubusercontent.com/9029957/242740721-53fb74c6-7648-4be1-8fa2-2d961330954e.png

— Reply to this email directly, view it on GitHubhttps://github.com/CaltechOpticalObservatories/NGPS/issues/29#issuecomment-1572869205, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFCPAKA4D5PBCSJPUMEMJ6LXJEIZHANCNFSM6AAAAAAYPDIPOE. You are receiving this because you modified the open/close state.Message ID: @.***>

[chazshapiro]

Let's just use whatever the OtM puts in the OTMflag output field.

[jenniferwillow]

I have changed the text to make it shorter and now it's no longer truncating. I think this issue is closed.