Caltinor / Project-MMO-2.0

A continuation of Harmony's Project MMO project
38 stars 22 forks source link

Include the `base` Modifier in All Numeric Perks #502

Closed SomewhatDamaged closed 5 months ago

SomewhatDamaged commented 6 months ago

Describe the solution you'd like Right now, base is only valid on pmmo:temp_attribute, pmmo:damage_boost, and pmmo:attribute. It would be nice if this could be added to other perks that deal with numbers.

pmmo:break_speed: Addition to the speed. (default 0) pmmo:jump_boost: Addition to the height. (default 0) pmmo:damage_reduce: Subtraction from damage. (default 0) pmmo:villager_boost: Addition to reputation increase. (default 0) pmmo:tame_boost: Multiplier to the boost. (default 1)

Note: since both pmmo:effect and pmmo:breath have two sets of variables, in vastly different scales, either a judgement call about which would be the most useful to have be base would need to be made or you could have base_<value> for each of their variables.

Why is this feature needed Expanding an already useful value to cover much more ground. Also for this person

Describe alternatives you've considered A jumping castle.

Additional catext Purricane cats