search

Caltinor / Project-MMO-2.0

A continuation of Harmony's Project MMO project
37 stars 21 forks source link

Could be added "applies_to" in "perk = "pmmo:attribute" #517

Open Shadowyjp opened 1 month ago

Shadowyjp commented 1 month ago

Describe the solution you'd like Could be added "applies_to" in "perk = "pmmo:attribute"

Why is this feature needed So, im trying to give attribute (critic chance) using combat xp and bow xp, but i dont want to have the critic chance from combat when im using a bow, or use the critic from archery when im use a sword. If have "applies_to" i could use it, and set as i want - Archery critic only applies in bows, and combat only in swords.

Describe alternatives you've considered I know that have the damage_boost, but with the applies_to, could be done more things than i said.

SomewhatDamaged commented 1 month ago

pmmo:attribute is typically a consistent bonus. It can't really be turned on and off in this way because it is only applied—not removed. If you give a buff to the player's attribute, it will stick around until you remove it and it affects the entire player.

What would be better, to give "critical" damage, would be to make a damage boosting perk that has chance = 0.1 (10% chance) but gives a much larger bonus to damage.

SomewhatDamaged commented 1 month ago

See here for details on what chance does.

Caltinor commented 1 month ago

More and more i see the use for context in events. In any case, there is already a perk the temporarily gives attributes, pmmo:temp_attribute but it doesn't have the item discrimination that you want from the applies_to property. I think I need to finish the default packs for 1.21 first, but I could start working on this for 1.21