Caltinor / Project-MMO-2.0

A continuation of Harmony's Project MMO project
37 stars 21 forks source link

A Way To Disable Vein Mining Values on an Item #522

Closed SomewhatDamaged closed 3 weeks ago

SomewhatDamaged commented 1 month ago

Describe the solution you'd like A method, in datapack, to disable vein mining values.

Why is this feature needed Because of how the values are generated in a fresh datapack (as 0 and 0.0), even override can't be used because that would disable vein mining for every item by default.

Consequently, there is no way (short of a datapack filter to disable the file from the internal datapack) to stop an item with vein mining stats from having them.

Describe alternatives you've considered Maybe setting the value to negative would do it? Should be easy to check for.

Additional context Was asked in 1.18.2 support channel (Discord link)

Caltinor commented 1 month ago

IIRC this was fixed in later versions but was not backported.

Caltinor commented 1 month ago

0.0 is considered "unconfigured" which is used to ignore configurations that generate with nothing. Your best option is to set both to some thing astronomically slow like 0.0000000001 so that it's not zero but so low a user could never exploit it

SomewhatDamaged commented 3 weeks ago

Bonus note: chargeCap should be chargeRate in this line