Caltinor / Project-MMO-2.0

A continuation of Harmony's Project MMO project
37 stars 21 forks source link

1.18.2 - "Perks.For_Event.SKILL_UP" Events Fire Incorrectly #525

Closed MattB70 closed 1 month ago

MattB70 commented 1 month ago

Describe the bug "Perks.For_Event.SKILL_UP" events fire on respawn.

Expected behavior "Perks.For_Event.SKILL_UP" events should fire once on skill up, and never any other time.

To Reproduce Steps to reproduce the behavior:

  1. Set a "say" command for a Perks.For_Event.SKILL_UP event.
  2. die
  3. command will print to the chat

Screenshots image These chat messages should only fire on skill up, I also update a scoreboard objective to track stats as I mentioned wanting to do a couple years ago. This one bug is all that's stopping it.

Versions:

MattB70 commented 1 month ago

This still happens, but only with command perks. Perhaps it's related to the lack of propertyDefaults CompoundTag passed during it's registry? I wasn't able to clearly see anything wrong, but that's the only clear difference between the command perk and the others. Again, it's only happening with command perks, such as printing a command to chat, or storing a scoreboard element.