search

Caltinor / Project-MMO-2.0

A continuation of Harmony's Project MMO project
37 stars 21 forks source link

Rats Mod Incompatibility #563

Open Waterspark63 opened 3 days ago

Waterspark63 commented 3 days ago

Describe the bug A Player on the server had gotten tamed rats, and got up to having a fisherman rat. When the rat fishes, there are some items that are fine, but on some occasions, I believe on vanilla fish, PMMO tries to reward the rat for fishing, causing the entire server to crash. Have not been able to check as of now, but other rat jobs may also be affected by this bug.

Mod Versions PMMO: 1.20.1-1.3.22 Rats: 1.20.1-8.1.2 LexForge: 47.2.30

Paste your crash log here Latest.log latest.log

Crash Report crash-2024-06-29_12.26.16-server.txt

Caltinor commented 3 days ago

So, looks like the issue is that the ItemFishedEvent is firing, but there is not loot for that event. PMMO dangerously assumes that there will be at least one loot item and tries to grab that first item. I would like to know if the Rats mod is doing something to the loot in that event. I would suggest not firing an event that has no loot. That said, I will add a catch for an empty list on the pmmo side, since that was a dangerous assumption to make.