search

Caltinor / Project-MMO-2.0

A continuation of Harmony's Project MMO project
37 stars 22 forks source link

Crash during combat #576

Open laneyfamily opened 2 months ago

laneyfamily commented 2 months ago

Describe the bug When in melee combat, occasionally I get a crash to desktop. Does not happen during ranged combat. Does not appear to be tied to enemy death, just the act of fighting with a weapon.

Expected behavior That the combat will continue till enemy dies, and game proceeds.

To Reproduce Steps to reproduce the behavior:

  1. Load Game
  2. Obtain weapon, So far my test has been with Tetra weapons.
  3. Find something to kill
  4. Attack
  5. Crash to desktop, not every time, no discernable pattern.

Versions:

Additional context Somewhat heavy mod list, the crash report also calls out Better Combat.
*Note that the crash report below calls out MNA as its the mob in question that died, this also happens with mobs from vanilla. I have other crash reports that do not call out MNA, but stack trace is the same.

crash-2024-02-22_21.40.45-client.txt debug.log latest.log

SomewhatDamaged commented 2 months ago

That crashlog is from February and doesn't show PMMO as being installed. Any chance you could link the one for this particular crash?

Caltinor commented 2 months ago

Where did you download this version of pmmo? Also, the first crash log shows that there's an issue with Majrusz's Accessories and Tetra, not with pmmo. The latter two have a pmmo error that shouldn't be possible though.

laneyfamily commented 2 months ago

Ha, that's what happens when you have your view sorted by date in the explorer window, and the view in the upload is by name.... lol Here is the right log file, sorry about that.

Mod is downloaded from Curseforge

crash-2024-07-13_07.40.55-client.txt

Caltinor commented 2 months ago

So, Minecraft 1.20.1 runs on Java 17. You are running Java 21. There's also the possibility this happens because of the Forge version (47.3.5). There's mixed results after 47.1.3. I would first try running the correct Java version, then try downgrading Forge. We tried to reproduce this issue on our end, and haven't had the crash, so anything you can do to detail consistently reproducible steps would be great.

laneyfamily commented 2 months ago

Let me start by downgrading the Java, I believe if I go as far back as Forge 47.1.3 Quark will break, but I'll test that next.

Ofcourse, I can disable Quark also in testing, just pointing out it would be an additional variable

laneyfamily commented 2 months ago

Setting Java to jdk-17.0.10.7 has no impact, same conditions as prior and crashed:

crash-2024-07-13_09.23.09-client.txt

laneyfamily commented 2 months ago

image

I can downgrade to Forge 47.1.3, but it will impact troubleshooting consistency as one of the primary contributors (BetterCombat) will need to be downgraded also.

Will downgrading/disabling for testing yield viable results or will this be too inconsistent to be a valid test? I'll hold to get your insight before doing further testing.

Caltinor commented 2 months ago

you should be okay with 47.2.0. People have had success with that one.

laneyfamily commented 2 months ago

Same results running forge 47.2.0 on Java 17.0.10.7

crash-2024-07-13_18.56.54-client.txt

laneyfamily commented 1 month ago

As an update, trying to see a pattern here, I believe this happens most often during a critical strike where in you jump and slash and get the particle effects, I've noticed the crash corresponds most often with that (I think.... )

I can state that it happens with vanilla weapons as well (sword specifically)