Salvage block UI bugs and config issues

[schindlershadow]

Describe the bug 1: opening the salvage block stops player inventory from being rendered. I suspect this is caused by the salvage block "helpful tips" as if you open it in a way that the player stops looking at the block when the ui is opened, the inventory is rendered correctly 2: The salvage block "helpful tips" config is ignore and is always shown despite "Enable Salvage Tips" = false

Expected behavior 1: player inventory is rendered 2: tips are not shown

To Reproduce Steps to reproduce the behavior:

1. right click salvage block

Screenshots

Versions:

• Minecraft: 1.21.1
• Loader: neoforge 21.1.26
• PMMO: 2.4.12

[Caltinor]

1 likely has nothing to do with that renderer. The tooltip is an overlay that hooks into the HUD and just renders text. The only interaction with the inventory is to get the item held in the players hand and still only does that if the player is crouching. I will still look into it though just in case there is something else happening here.

2 is definitely a bug, so i'll work on that.

[schindlershadow]

if your op'ed #1 does not happen for some reason

[TheTaterLord]

Can you reproduce this issue with just pmmo installed? This sounds like a conflict with some sort of performance boosting mod in my opinion

[Caltinor]

I agree. there's something conflicting. this is pmmo with a couple dozen mods from my own singleplayer playthrough. cheats are not enabled.

[schindlershadow]

1 confirmed caused by ImmediatelyFast https://github.com/RaphiMC/ImmediatelyFast/issues/271

keeping open for #2 2: The salvage block "helpful tips" config is ignore and is always shown despite "Enable Salvage Tips" = false