Crash when trying to break Stargate from Stargate Journey mod

Caltinor / Project-MMO-2.0

A continuation of Harmony's Project MMO project

38 stars 22 forks source link

Crash when trying to break Stargate from Stargate Journey mod #599

Open DrSigma4164 opened 4 weeks ago

DrSigma4164 commented 4 weeks ago

Describe the bug Along with your mod, I have Stargate Journey installed which adds Stargate. So, when I try to break the gates (I only left-click with the pickaxe), they don't break, but an error is issued, and the client crashes (I play on a dedicated server). The author of the Stargate Journey mod asked to contact you.

Paste your crash log here Minecraft: 1.20.1 Forge: 47.3.1 Stargate Journey: 0.6.31 Project MMO: 1.4.25

crash report and debug.log: https://gist.github.com/f3a132db396c6f21c1a569bbae561f7c.git

SomewhatDamaged commented 4 weeks ago

Any chance you could test this without Sinytra? A lot of these bugs get caused by a non-pure Forge install.

DrSigma4164 commented 4 weeks ago

Give me 20 minutes, I'll check now

DrSigma4164 commented 4 weeks ago

I tried without the connector, but everything still crashes https://gist.github.com/b54a16e415dd7be2806e0a9c407875ce.git

SomewhatDamaged commented 4 weeks ago

Thanks for that. Caltinor, the developer, should be able to get to the bottom of this now.

Caltinor commented 4 weeks ago

This is the same as the DT auto values issue. The gate block expects a world context that pmmo cannot provide via autovalues. Give the gates a configuration so autovalues don't kick in, and it'll be fine.

DrSigma4164 commented 3 weeks ago

Now, it doesn't crash when I break a certain block, but when an item is in inventory and I hover over it, it crashes. How do I completely disable StarGate from being processed by your mod? Because there are many such blocks and I don't need mechanics like requirements for breaking this block or using an item etc. https://gist.github.com/DrSigma4164/7e90e0c66279f17c56cbf213996492c9

Caltinor commented 3 weeks ago

Same thing but for all the requirements and experience. Of those blocks. You should only need to do this for the gate blocks themselves.

DrSigma4164 commented 3 weeks ago

I added a file with these values, but still, when I hover over the item, it crashes. Here is the crash report, actually the datapack file, and debug.log https://gist.github.com/DrSigma4164/59e46de04c799910571710994cdcf553

Caltinor commented 3 weeks ago

make sure to set the block place and break settings on the item. the block configs only apply when the object is in the world. in the inventory, it's an item.

SomewhatDamaged commented 3 weeks ago

EDIT: updated zip. Just drop it in your datapacks folder in your savegame and /reload it. sg_pmmo_fix.zip

Try using this datapack. It should set "mining": 0 requirement and xp on all sgjourney blocks.

DrSigma4164 commented 3 weeks ago

Perfectly!!! Now don't crash, I thought in the field "isTagFor" you can specify only the tags of items or blocks, not the expression you specified. Thank you. It seems to me that a fix should be made for the Stargate mod, so that everyone who will use it together with PMMO does not have to install this datapack.

And one more question, is there a way to remove the tooltip inscription that is only for items from the Stargate mod in the photo? They are empty, but just take up space, but they are useful in subjects where it is needed.

SomewhatDamaged commented 3 weeks ago

That tooltip showing is a bug that is known and awaiting a fix: https://github.com/Caltinor/Project-MMO-2.0/issues/591