Calvagone / campsis

A generic PK/PD simulation platform based on rxode2 and mrgsolve engines.
https://calvagone.github.io/
GNU General Public License v3.0
8 stars 3 forks source link

Regression in performances with events #53

Closed luyckxn closed 3 years ago

luyckxn commented 3 years ago

Bug seems to be there already in CAMPSIS v0.8 but the slowness is amplified in CAMPSIS v0.9 due new argument 'scenarios' in the simulate method.

After investigation, the issue is, again, the R method .findInheritated method and appears at the second iteration of events. The table provided for the second iteration has a first class: "grouped_df".

The fix is simply to return a "tbl_df" (i.e. call ungroup() ).