search

Calvin-Huang / react-native-device-brightness

Screen brightness adjustment tool for ReactNative iOS and Android.
MIT License
49 stars 59 forks source link

Remove createJSModules override #10

Closed k4r1 closed 7 years ago

k4r1 commented 7 years ago

RN 0.47 introduces a breaking change to createJSModules: facebook/react-native@ce6fb33

This commit upgrades as advised in the commit message of ce6fb33. commit a3e180af3155ea7e72395528835a844ba5029622

JCMais commented 7 years ago

@Calvin-Huang any plans to publish a new release to npm? Currently it's impossible to build this on android with RN >= 0.47 without this changes.

Calvin-Huang commented 7 years ago

@JCMais Sorry about the delay, I wanna check whether any other potential issue on it. I'll publish another version today.

Calvin-Huang commented 7 years ago

@JCMais Thanks for your noting. I had published version 1.2.0 😉

JCMais commented 7 years ago

Thanks @Calvin-Huang