Fix issue #121 and #123

Calysto / matlab_kernel

Jupyter Kernel for Matlab

Other

469 stars 76 forks source link

Fix issue #121 and #123 #124

Closed ha7ilm closed 5 years ago

ha7ilm commented 5 years ago

Replacing those two lines with pass fixed Calysto#121 for me, although it does not look good to remove error handling there.
Returning __matlab at the end of _matlab fixed Calysto#123 for me.
My MATLAB version is 9.5.0.944444 (R2018b)

ha7ilm commented 5 years ago

After the fix, MATLAB errors look like this for me:

blink1073 commented 5 years ago

Thanks! I'll make a release with this fix tomorrow morning

blink1073 commented 5 years ago

Released as 0.16.7, cheers!

ha7ilm commented 5 years ago

Sounds goods! Thanks!