Calysto / metakernel

Jupyter/IPython Kernel Tools
BSD 3-Clause "New" or "Revised" License
344 stars 84 forks source link

add Error_display method to _metakernel.py #205

Closed jld23 closed 4 years ago

jld23 commented 4 years ago

add Error_display method that will allow an error to be thrown and also display non-text objects

In the SAS Kernel, based on metakernel, there are two streams of information -- the log and the list. In parsing the log you can determine if there is an error and lag the cell as such but in a log program there could be valid output (in the form of HTML) that is helpful to the user.

This commit adds a new method to not change existing behavior.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.4%) to 75.526% when pulling 1991ec4ac64ac0b7c1d67ef896222f486efe5a83 on jld23:master into c0379fa80497f79972f38c5eb0f03db6631fafb0 on Calysto:master.

dsblank commented 4 years ago

This looks reasonable. Could you add an example in the example directory in lieu of a test?

dsblank commented 4 years ago

Thanks!