Calysto / metakernel

Jupyter/IPython Kernel Tools
BSD 3-Clause "New" or "Revised" License
344 stars 84 forks source link

Updated dot magic, with tests #268

Closed dsblank closed 1 year ago

dsblank commented 1 year ago

This PR:

dsblank commented 1 year ago

@blink1073 How are you? I found some time to work on a couple of metakernel issues. I'm over my head on this one as I don't know github workflow syntax for how to install graphviz for the different OS test matrix entries.

blink1073 commented 1 year ago

Hey @dsblank, I'm good, how are you? I'll push some changes :)

blink1073 commented 1 year ago

I think it would make sense to skip the pydot tests if graphviz is not installed, to make it easier to run the tests in other environments/OSes.

dsblank commented 1 year ago

@blink1073 Good idea! I skipped the tests when not on linux. Thank you for your help, as always!

blink1073 commented 1 year ago

Let me know when you're ready for a release

dsblank commented 1 year ago

All ready for release! Thank you!

blink1073 commented 1 year ago

Done!