CamDavidsonPilon / Probabilistic-Programming-and-Bayesian-Methods-for-Hackers

aka "Bayesian Methods for Hackers": An introduction to Bayesian methods + probabilistic programming with a computation/understanding-first, mathematics-second point of view. All in pure Python ;)

http://camdavidsonpilon.github.io/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/

MIT License

26.55k stars 7.85k forks source link

Work in progress -- updates for 2018 #387

Open mehemken opened 6 years ago

mehemken commented 6 years ago

I'm working through this book and I'm noticing perhaps a few things need to be updated. There may have been something in Chapter one (PyMC3) but I've only now got around to submitting a PR. I imagine I could find a few more as I work through the book. So maybe I'll continue to add them to this PR.

Thoughts?

CamDavidsonPilon commented 6 years ago

Hey @mehemken, this is fine, however can you annotate if your changes are matplotlib 1.x vs 2.x?

mehemken commented 6 years ago

Great, thanks @CamDavidsonPilon. I'll add that tomorrow morning when I sit down to study the book again. I believe I'm using Matplotlib 2.x because I just upgraded to Ubuntu 18.04 and installed the latest packages provided by Anaconda.

Where would these annotations need to be written?

CamDavidsonPilon commented 6 years ago

In the PR. I should update both Pymc2 and 3 to use the latest matplotlib, so this helps.

mehemken commented 6 years ago

Matplotlib version 2.2.2

I can confirm that I'm using matplotlib version 2.2.2

mehemken commented 6 years ago

Chapter 2 PyMC3

The link to the separation plots paper is broken:

http://mdwardlab.com/sites/default/files/GreenhillWardSacks.pdf

I found one that might be the same paper?

https://onlinelibrary.wiley.com/action/downloadSupplement?doi=10.1111%2Fj.1540-5907.2011.00525.x&attachmentId=164305447

I don't know how permanent this link might be. Should I add it?

[EDIT]

This appears near the end of the chapter. Shortly after the goodness of fit scatterplots.

[EDIT 2] The file separation_plot.py is also affected.