CamDavidsonPilon / Probabilistic-Programming-and-Bayesian-Methods-for-Hackers

aka "Bayesian Methods for Hackers": An introduction to Bayesian methods + probabilistic programming with a computation/understanding-first, mathematics-second point of view. All in pure Python ;)
http://camdavidsonpilon.github.io/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/
MIT License
26.51k stars 7.84k forks source link

corrected the code `at` and changed to `pt` #555

Closed Shayan-B closed 1 year ago

Shayan-B commented 1 year ago

correcte a typing blip in code for pytensor.tensor import

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

twiecki commented 1 year ago

Actually it should be import pytensor.tensor as pt everywhere. I think in another file it was also using tt maybe.

Shayan-B commented 1 year ago

Actually it should be import pytensor.tensor as pt everywhere. I think in another file it was also using tt maybe.

You are right actually, I just gave this recommendation in order to make it compatible with the code after it, so if we change it to pt we have to change the T.stack in the following code too.

twiecki commented 1 year ago

so if we change it to pt we have to change the T.stack in the following code too.

Yes, you're right. Can you make these changes?

Shayan-B commented 1 year ago

np

twiecki commented 1 year ago

Same in chapter 2: https://github.com/CamDavidsonPilon/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/pull/554/files#diff-9fc4a0e7834209ea34b4d28c88fadf5af42096ab64f5b4b0e4832b1aef201c0eR432 and 5: https://github.com/CamDavidsonPilon/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/pull/554/files#diff-c3fc32a9c505ecf8a7b24bead1eb807d7b267b5cf3675a302a916457892d9b8fR1090, 6: https://github.com/CamDavidsonPilon/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/pull/554/files#diff-199fdfea5b6b81e04e46186b1c01db27f75d876ddaad83a7e2c6c92f012394e2R1171

twiecki commented 1 year ago

Great, did you rerun the NBs to make sure it's all working?

Shayan-B commented 1 year ago

Great, did you rerun the NBs to make sure it's all working?

I wasn't at my computer to test it, just replaced by search but I can check them later to see if everything is working ok. I will comment it here if everything run OK.

Shayan-B commented 1 year ago

Great, did you rerun the NBs to make sure it's all working?

There was no error related to pytensor. there were some errors and warnings with some other parts which needs to be fixed later.

CamDavidsonPilon commented 1 year ago

Sounds like it's good to merge?

twiecki commented 1 year ago

Yes!

@Shayan-B Can you open an issue about the errors that are present so we don't lose track?

On Mon, Feb 13, 2023 at 7:54 AM Cameron Davidson-Pilon < @.***> wrote:

Sounds like it's good to merge?

— Reply to this email directly, view it on GitHub https://github.com/CamDavidsonPilon/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/pull/555#issuecomment-1427130019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFETGAZ2MTDI4NKHKHR3WTWXFEXBANCNFSM6AAAAAAUYQATHQ . You are receiving this because you commented.Message ID: <CamDavidsonPilon/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/pull/555/c1427130019 @github.com>

Shayan-B commented 1 year ago

@twiecki np, I'll do it.