Closed nomennominatur closed 1 year ago
Yea, I like this: the user is being explicit about plots been shown, and so the computer should obey.
PR looks good!
Thanks @nomennominatur!
Thanks @CamDavidsonPilon for the fast review & merge, and also for the kind reception! I feel honored having made a miniscule contribution to such a wonderful project.
The plotting code section for
check_assumptions
in mixins.py has been moved so that it will plot Schoenfeld residuals whenevershow_plots = True
, regardless of the numeric test result.Justification:
(This is my first ever pull request, so please bear with me, if I did something wrong or inadvertently have violated the code of conduct. Feedback appreciated.)