search

CamDavidsonPilon / lifelines

Survival analysis in Python
lifelines.readthedocs.org
MIT License
2.35k stars 557 forks source link

Incompatibility of v0.27.8 with Python <3.9 due to `importlib.resources.files` #1568

Closed TonyYanOnFire closed 9 months ago

TonyYanOnFire commented 11 months ago

Hi there, The latest version of lifelines, v0.27.8, has started using importlib.resources.files for data loading. This feature was introduced in Python 3.9. Therefore, lifelines v0.27.8 is not compatible with Python 3.8 and earlier versions. I noticed that this was not reflected in the changelog. I suggest mentioning this in the documentation or changelog for clarity.

CamDavidsonPilon commented 11 months ago

Hi @TonyYanOnFire,

You're correct, this should be made explicit in the setup.py, too. The error appears when trying to load data only, is that correct?

TonyYanOnFire commented 11 months ago

Yes, that is correct.

On Wed, Oct 25, 2023 at 20:18 Cameron Davidson-Pilon < @.***> wrote:

Hi @TonyYanOnFire https://github.com/TonyYanOnFire,

You're correct, this should be made explicit in the setup.py, too. The error appears when trying to load data only, is that correct?

— Reply to this email directly, view it on GitHub https://github.com/CamDavidsonPilon/lifelines/issues/1568#issuecomment-1779147356, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANIROSWRZBH2XDG2T2B34LTYBD7R3AVCNFSM6AAAAAA6OXOVDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZGE2DOMZVGY . You are receiving this because you were mentioned.Message ID: @.***>