CamDavidsonPilon / lifelines

Survival analysis in Python
lifelines.readthedocs.org
MIT License
2.37k stars 560 forks source link

Error in check assumptions #614

Closed CamDavidsonPilon closed 5 years ago

CamDavidsonPilon commented 5 years ago

https://github.com/LeoGrin/PSC/blob/master/xena_scraping.ipynb

cc @leogrin, can you detail the error your saw in "check the assumptions" section?

LeoGrin commented 5 years ago

hi @CamDavidsonPilon I've updated the notebook to show the error. Tell me if you need other info.

CamDavidsonPilon commented 5 years ago

Great, thanks. This was recently fixed (yesterday?) in v0.17.3 - you can pip install lifelines==0.17.3 to get it.

LeoGrin commented 5 years ago

Oh cool, thank you ! Also I'm curious : how did you tumble on my notebook ?

CamDavidsonPilon commented 5 years ago

That's a fair question:

I sometimes go a global github search for lifelines to see how people are using the API. It's like a passive way to get user feedback.

LeoGrin commented 5 years ago

Haha that's a good idea