search

CamDavidsonPilon / lifelines

Survival analysis in Python
lifelines.readthedocs.org
MIT License
2.36k stars 558 forks source link

make max_steps a internal variable in cox model #793

Open CamDavidsonPilon opened 5 years ago

CamDavidsonPilon commented 5 years ago

Related to https://datascience.stackexchange.com/questions/56608/python-lifelines-convergencewarning-newton-raphson-failed-to-converge-suffici/56637#56637

juancq commented 2 years ago

Having max_steps as a parameter to the fit method would also be useful with datasets with large number of variables, where convergence is extremely slow.

I would also add precision as another parameter to the fit method, to allow control over the convergence.

CamDavidsonPilon commented 2 years ago

👍 I'll put it in the next release