search

CamFlow / camflow-dev

Generates kernel patch for CamFlow Linux Provenance Capture.
http://camflow.org/
GNU General Public License v2.0
26 stars 15 forks source link

`pckprov` lacks concreteness #86

Closed michael-hahn closed 5 years ago

michael-hahn commented 5 years ago

This issue is related only to tinkerbell branch.

Current design that assigns content to pckprov using the address operator & is not ideal for tinkerbell design.

https://github.com/CamFlow/camflow-dev/blob/75523306e60371909e27d44c7fadad9af212a0e2/security/provenance/hooks.c#L2191

tfjmp commented 5 years ago

What would be a helpful form?

michael-hahn commented 5 years ago

Is it possible to have provenance_parse_skb_ipv4 return the instance/pointer of prov instead of having prov as a parameter? https://github.com/CamFlow/camflow-dev/blob/75523306e60371909e27d44c7fadad9af212a0e2/security/provenance/hooks.c#L2206

Ideally, after pckprov is declared in provenance_socket_sock_rcv_skb, it can be assigned by provenance_parse_skb_ipv4.

tfjmp commented 5 years ago

https://github.com/CamFlow/camflow-dev/commit/66213a636c1c3a457d334a5c58e1e1619fe8b72c <<< change made in this commit.

tfjmp commented 5 years ago

@michael-hahn if ok, please close issue.