search

Cambalab / vue-admin

An open source frontend Framework for building admin applications running in the browser on top of REST, using ES6 and Vue.js
GNU General Public License v3.0
132 stars 24 forks source link

Add a pre-commit hook to avoid eslint errors/warnings #158

Closed sgobotta closed 5 years ago

sgobotta commented 5 years ago

Is your feature request related to a problem? Please describe.

7 enforces developers to write clean code according to prettier eslint rules. It would be nice to have a pre-commit hook that avoids developers committing code with errors or warnings.

Describe the solution you'd like Whenever a developer commits, a pre-commit hook should run the lint package.json script.

Note that we don't want to automatically fix errors/warnings, npm run lint is already configured to do the job.

Describe alternatives you've considered Lint staged seems to be a pretty good and simple solution.

TheAkshitS commented 5 years ago

I'm working on it. :)

C3-TKO commented 5 years ago

I am currently working on it - see PR #183