Cambalab / vue-admin

An open source frontend Framework for building admin applications running in the browser on top of REST, using ES6 and Vue.js
GNU General Public License v3.0
132 stars 24 forks source link

210 the admin component ignores custom unauthorized layouts #211

Closed sgobotta closed 4 years ago

sgobotta commented 4 years ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

Fixes #210

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce the cases. Please also list any relevant details for your test configuration

Instructions:

1. Use a custom layout in the authorized prop for the Admin component
2. Visit an anauthorized page

Expected result: The layout should be seen

Checklist:

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

codecov-io commented 4 years ago

Codecov Report

Merging #211 into develop will increase coverage by 2.28%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #211      +/-   ##
===========================================
+ Coverage    42.24%   44.53%   +2.28%     
===========================================
  Files           94       94              
  Lines          748      750       +2     
  Branches        30       30              
===========================================
+ Hits           316      334      +18     
+ Misses         429      413      -16     
  Partials         3        3
Impacted Files Coverage Δ
src/components/Core/src/Core.vue 0% <ø> (ø) :arrow_up:
src/components/Admin/src/Composer.vue 0% <ø> (ø) :arrow_up:
src/components/Admin/src/defaults.js 100% <100%> (ø) :arrow_up:
src/components/Admin/src/Admin.vue 100% <100%> (ø) :arrow_up:
src/va-auth/src/store/modules/mutations.js 66.66% <0%> (+16.66%) :arrow_up:
src/va-auth/src/store/modules/getters.js 60% <0%> (+20%) :arrow_up:
src/va-auth/src/store/modules/actions.js 61.53% <0%> (+30.76%) :arrow_up:
src/components/Admin/src/Authenticated.vue 100% <0%> (+50%) :arrow_up:
src/components/Admin/src/Unauthenticated.vue 100% <0%> (+50%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19a3f4e...607c3c3. Read the comment docs.