Cambricon / triton-linalg

Development repository for the Triton-Linalg conversion
Apache License 2.0
131 stars 10 forks source link

[Bufferization]: one-shot bufferization illegal #5

Closed YeBug closed 2 months ago

YeBug commented 2 months ago

In classTritonScatteredStoreOpConversion, funcmatchAndRewrite image bufferization::ToTensorOp not set restrict and writable, after convert to linalg mlir, this bufferization.to_tensor Op is illegal when using one-shot bufferization. Wonder why ScatteredLoadOp has the restric and writable attribute but ScatteredStoreOp hasn't ?

hesse-x commented 2 months ago

这个应该是两个true的,这样改没问题,我这边确认一下,之后会提一个pr修复这个问题

hesse-x commented 2 months ago

https://github.com/Cambricon/triton-linalg/pull/10 修复已经提交RP,感谢反馈。