search

Cambricon / triton-linalg

Development repository for the Triton-Linalg conversion
Apache License 2.0
144 stars 12 forks source link

fix(triton_to_linalg pass): add memref::LoadOp, memref::StoreOp and triton::ExternElementwiseOp as legal operation #7

Closed zhujian19891203 closed 3 months ago

zhujian19891203 commented 3 months ago
  1. file lib/Conversion/TritonToLinalg/LoadStoreConversion.cpp, TritonScalarLoadOpConversion class use memref::LoadOp and TritonScalarStoreOpConversion class use memref::StoreOp. Case: 05-layer-norm.py
  2. triton::ExternElementwiseOp can mark legal op directly for triton_to_linalg pass. Case: 07-extern-functions.py
hesse-x commented 3 months ago

非常感谢您提供的pr。我们今天更新了一下仓库的代码，这两个问题的修复已经包含在了更新的代码中 https://github.com/Cambricon/triton-linalg/blob/73ff981fbebff08b4e733c29495c46b038ebe902/lib/Conversion/TritonToLinalg/TritonToLinalg.cpp#L1641

https://github.com/Cambricon/triton-linalg/blob/73ff981fbebff08b4e733c29495c46b038ebe902/lib/Conversion/TritonToLinalg/TritonToLinalg.cpp#L761

在此依然感谢您对triton-linalg项目的贡献，如果你有其他建议或发现其他问题，请随时打开新的 PR 或 Issue。再次感谢你的支持和理解！

zhujian19891203 commented 3 months ago

非常感谢您提供的pr。我们今天更新了一下仓库的代码，这两个问题的修复已经包含在了更新的代码中

https://github.com/Cambricon/triton-linalg/blob/73ff981fbebff08b4e733c29495c46b038ebe902/lib/Conversion/TritonToLinalg/TritonToLinalg.cpp#L1641

https://github.com/Cambricon/triton-linalg/blob/73ff981fbebff08b4e733c29495c46b038ebe902/lib/Conversion/TritonToLinalg/TritonToLinalg.cpp#L761

在此依然感谢您对triton-linalg项目的贡献，如果你有其他建议或发现其他问题，请随时打开新的 PR 或 Issue。再次感谢你的支持和理解！

Copy that. Thank you.