search

Cambridge-Community-Kitchen / cck-volunteer-web-app

https://volunteer.cckitchen.uk
3 stars 2 forks source link

Delivery's notes field truncated #15

Closed faceless-stoat closed 5 months ago

faceless-stoat commented 1 year ago

In one of today's deliveries (details provided privately), side-by-side comparison of old and new apps showed that the new app (this one) is truncating a long 'notes' field. The 'notes' field shown by the old app is something like 282-286 characters (depending how you count); the new app's web display (/route) and JSON API (/api/cck/route) both truncated it to 191 characters. The truncation point is not obviously a difficult character, so it looks like a length limitation.

faceless-stoat commented 6 months ago

This bug is still present, with the same behaviour. My route had a new recipient with extensive important notes; about half of them were missing from the app, and the truncation isn't completely obvious to deliverers (not mid-word). (Fortunately I was suspicious, and checked against the paper sheet.)

Has anyone looked into where a truncation / length limit might be in the data's journey from Google-land into this web app?

faceless-stoat commented 6 months ago

(@pdl noted elsewhere that this is simply because the notes database column, among others, have lengths of 191.)

faceless-stoat commented 5 months ago

This fix was merged long ago (although I haven't knowingly delivered an affected route since to check it personally).