Open dorchard opened 2 weeks ago
@isaacaka to pick up writing the tests
The smop
translator is being implemented in PR #17. This PR also parametrizes the matlab_engine
fixture (and renames it to ustar_cp
) so that it can generate either the matlab engine instance, or the module containing the translated python code.
Thanks. We now have a candidate set of tests for cpdFmax2pCp3.m
here: (https://github.com/Cambridge-ICCS/ONEFlux/pull/51).
TODO:
cpdFmax2pCp3.py
and let us know the results.cpdFmax2pCp
and similarly to the above, run the tests and let us know the results.In both cases the structure/scaffolding of the tests will need tweaking slightly to get it to address the Python version of the code rather than the matlab; I think do what works for now so that we can get the info we need to do the comparison of the two.
I have translated the code to python and currently it can pass 16 out of 28 tests.
We want to evaluate possible translation techniques
We are going to use
cpdFmax2pCp3.m
as a test case; @j-emberton is making some tests so it is ready for that.